Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle dependencies not existing before #935

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Handle dependencies not existing before #935

merged 1 commit into from
Jul 10, 2024

Conversation

kam193
Copy link
Contributor

@kam193 kam193 commented Apr 19, 2024

If a dependency didn't exist before, there is no existing dependency blob key.

For example, introducing a new dependency to the existing service, results in
the following error on updating:

Error applying service settings from: Network-Information\nTraceback (most recent call last):
  File \"/var/lib/assemblyline/.local/lib/python3.11/site-packages/assemblyline_core/scaler/scaler_server.py\", line 626, in _sync_service
    if profile.dependency_blobs[dependency_name] != dependency_blob:
       ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^\nKeyError: 'netinfo_cache'

A similar error appears if you try to rename a dependency

@kam193
Handle dependencies not existing before
296bc1c 
If a dependency didn't exist before, there is no existing dependency blob key.
@cccs-douglass cccs-douglass merged commit fff8434 into CybercentreCanada:master Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cccs-douglass cccs-douglass cccs-douglass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kam193 @cccs-douglass